Skip to content
This repository has been archived by the owner on Feb 23, 2021. It is now read-only.

Add dark theme #7

Merged
merged 5 commits into from
Oct 21, 2017
Merged

Add dark theme #7

merged 5 commits into from
Oct 21, 2017

Conversation

blue0513
Copy link
Contributor

I added dark theme personally (#3)
However, since I don't know about Vue.js first of all, some parts of them may be not coded properly.

screen shot 2017-10-18 at 0 06 44

screen shot 2017-10-18 at 0 06 58

screen shot 2017-10-18 at 0 06 27

screen shot 2017-10-18 at 0 05 59

To check them, on src/renderer/main.js, you should:

Vue.prototype.$theme = (() => {
    // const {classes} = themes.light.attach();
    const {classes} = themes.dark.attach();
    return classes;
  })();

Anyway, thank you for creating such a nice Qiita viewer!!

@nju33
Copy link
Owner

nju33 commented Oct 21, 2017

Hi @blue0513, Thank you for making the theme😆
However, I changed the theme name from dark to blue0513.

The theme can be changed as follows.
kapture 2017-10-21 at 22 14 05

@nju33 nju33 merged commit 069126b into nju33:master Oct 21, 2017
@nju33 nju33 removed the later merge label Oct 21, 2017
@blue0513
Copy link
Contributor Author

@nju33 Hi! Thx for merging my PR!! (It's almost the first merged case 👍 )

Anyway, another developer sent me a great PR about dark theme (see: blue0513#1)
But considering Git work flow, I will close the PR and recommend him to re-sent you the nice PR.

@JotaroS
Copy link

JotaroS commented Oct 22, 2017

Hi @nju33,
As @blue0513 said I created another theme which I dimmed a bit out of his theme.
And as I make sure all works well then I will put another PR to you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants