Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in ERRORR to close opened files #193

Merged
merged 6 commits into from
Mar 17, 2021
Merged

Conversation

jlconlin
Copy link
Member

This bug fix closes files nitape and notape in ERROR. It addresses #192.

@whaeck
Copy link
Member

whaeck commented Mar 17, 2021

I think we should pull this in develop first, in case we bump into more problems like this while working on the modern RECONR.

@jlconlin jlconlin changed the base branch from master to develop March 17, 2021 15:32
@jlconlin
Copy link
Member Author

I think we should pull this in develop first, in case we bump into more problems like this while working on the modern RECONR.

Changed.

@whaeck
Copy link
Member

whaeck commented Mar 17, 2021

Perfect. I'll wait till the tests finish running but I don't see an issue with this.

@whaeck whaeck merged commit be8aa50 into develop Mar 17, 2021
@whaeck whaeck deleted the fix/errorr-file-close branch May 13, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants