Compatibility with rust latest #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I've been trying to get nix running on Rust beta. I already applied some of these fixes, but haven't yet pushed. I will attempt to get nix running on the latest nightly at least. |
|
Re: the UtsName issue: apparently the recommended workaround is the one that I've used in #92 |
|
Thanks for the PR. Master should be fixed for Rust 1.0 Beta. I ended up merging #92 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I was trying to get some stuff done with mio on rust head, and just ended up in this sed-yak-shave, hope you can get some use out of it.
The only tricky bit is the clone implementation in UtsName, which i'm still not sure is 100% correct, but at least it gets tests passing.
Anyway, on this particular branch tests are green on today's rust. Hope it helps 😸