Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unistd: Use bindings from libc instead of our own #294

Merged
merged 1 commit into from
Mar 6, 2016
Merged

unistd: Use bindings from libc instead of our own #294

merged 1 commit into from
Mar 6, 2016

Conversation

kamalmarhubi
Copy link
Member

Refs #264

@kamalmarhubi
Copy link
Member Author

r? @posborne since I know you're around :-)

@posborne
Copy link
Member

posborne commented Mar 5, 2016

Looks like travis is undergoing maintenance. Changes look good though. @homu r+

@homu
Copy link
Contributor

homu commented Mar 5, 2016

📌 Commit afeb626 has been approved by posborne

@homu
Copy link
Contributor

homu commented Mar 5, 2016

⌛ Testing commit afeb626 with merge a512afe...

homu added a commit that referenced this pull request Mar 5, 2016
@homu
Auto merge of #294 - kamalmarhubi:unistd-libc, r=posborne
a512afe 
unistd: Use bindings from libc instead of our own

Refs #264
@posborne
Copy link
Member

posborne commented Mar 5, 2016

P.S. @kamalmarhubi You should take a look at #292. It seems to solve the test instabilities (although we may settle on another solution long term).

@homu
Copy link
Contributor

homu commented Mar 5, 2016

💔 Test failed - status

@kamalmarhubi
Copy link
Member Author

OS X failure is for fdatasync missing, though it's part of POSIX. libc crate only includes it for linux and android, so I have included it for only those systems. I've sent a PR to libc to add it to more platforms:

rust-lang/libc#211

@kamalmarhubi
Copy link
Member Author

@homu retry

@kamalmarhubi
Copy link
Member Author

@homu retry 6b24f60

@kamalmarhubi
Copy link
Member Author

oh I see

@homu r=@posborne b24f60

@homu
Copy link
Contributor

homu commented Mar 6, 2016

🙀 b24f60 is not a valid commit SHA. Please try again with 6b24f60.

@kamalmarhubi
Copy link
Member Author

@homu r=@posborne 6b24f60

@homu
Copy link
Contributor

homu commented Mar 6, 2016

⚡ Test exempted - status

@homu homu merged commit 6b24f60 into nix-rust:master Mar 6, 2016
homu added a commit that referenced this pull request Mar 6, 2016
@homu
Auto merge of #294 - kamalmarhubi:unistd-libc, r=@posborne
ea00191 
unistd: Use bindings from libc instead of our own

Refs #264
This was referenced Mar 6, 2016
Merged
Merged
@kamalmarhubi kamalmarhubi mentioned this pull request Mar 6, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kamalmarhubi @posborne @homu