-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make crate libc import public. #284
Conversation
I don't fully understand the implications of this. Seems related to #226? |
II'm OK with this change and I don't see another way to solve the problem while keeping the |
The other option is not exporting libc from |
Yet another option would be to change the Then again, I'm not sure how many users are depending on the macros. I think they were an interesting experiment but I'm not sure they really make sense in nix and certainly seem to clash with the other exposed APIs to some degree. |
For now, I'd like to get the build working again. For the discussion on whether to export libc or not we already have #226. |
Fair enough, @homu r+ |
📌 Commit 37a2884 has been approved by |
Make crate libc import public. On currently nightly I got an error regarding the public export of libc in sys::ioctl. It now requires us to import the extern crate publicly.
☀️ Test successful - status |
On currently nightly I got an error regarding the public export of libc in sys::ioctl. It now requires us to import the extern crate publicly.