Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null-check libc::group members before converting #1978

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Null-check libc::group members before converting #1978

merged 1 commit into from
Jan 27, 2023

Conversation

djkoloski
Copy link
Contributor

This mirrors the approach used for the From<&libc::passwd> for User impl.

@djkoloski
Null-check libc::group members before converting
09a85e2 
This mirrors the approach used for the `From<&libc::passwd> for User`
impl.
@djkoloski
Copy link
Contributor Author

Related: #1977 to guarantee validity of member pointers.

rtzoeller
rtzoeller approved these changes Jan 27, 2023
View reviewed changes
Copy link
Collaborator

@rtzoeller rtzoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 27, 2023

Build succeeded:

@bors bors bot merged commit 1a838c7 into nix-rust:master Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtzoeller rtzoeller rtzoeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djkoloski @rtzoeller