You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently src/sys/socket/consts.rs relies on many hard-coded constants. I've recently gone and updated many of these in #636, but there's more work to do here:
Get all constants that are still numbers upstreamed in libc for all supported nix platforms
Adapt src/sys/socket/consts.rs to use libc values
Refactor the constant declarations such that all constants are only declared once with a #[cfg] that only enables the constant on the correct platforms.
To determine what constants are available on what platforms, you can search through the source (see here for a list of sources of various platforms).
The text was updated successfully, but these errors were encountered:
647: merge socket constants r=Susurrus
> Refactor the constant declarations such that all constants are only declared once with a #[cfg] that only enables the constant on the correct platforms.
Closes#637
(same PR as #646 but from another branch, to see if buildbot has a problem with PR made from master branch)
Currently
src/sys/socket/consts.rs
relies on many hard-coded constants. I've recently gone and updated many of these in #636, but there's more work to do here:libc
for all supportednix
platformssrc/sys/socket/consts.rs
to uselibc
values#[cfg]
that only enables the constant on the correct platforms.To determine what constants are available on what platforms, you can search through the source (see here for a list of sources of various platforms).
The text was updated successfully, but these errors were encountered: