Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugins/lsp: add beancount-language-server #920

Merged
merged 1 commit into from
Jan 8, 2024
Merged

plugins/lsp: add beancount-language-server #920

merged 1 commit into from
Jan 8, 2024

Conversation

onemoresuza
Copy link
Contributor

Description

Add an option to enable the bencount-language-server.

CONTRIBUTING.md Checks

  • Formatting: The code is formatted with nix fmt.
  • Testing: The added language server is added to
    tests/test-sources/plugins/lsp/_lsp.nix as beancount.enable = true; on
    all-servers.plugins.lsp.servers.
  • Backwards Compatibility: The change does not break existing configurations.
  • nix flake check --all-systems succeeds.

GaetanLepage
GaetanLepage approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution !

@traxys traxys merged commit 6645fea into nix-community:main Jan 8, 2024
35 checks passed
@onemoresuza
Copy link
Contributor Author

You're welcome!

@onemoresuza onemoresuza deleted the beancount-language-server branch January 8, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onemoresuza @GaetanLepage @traxys