Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix wrong modules usage links #2038

Closed
wants to merge 1 commit into from

Conversation

HeitorAugustoLN
Copy link
Member

Currently, clicking those links leads to a page like this:

image

As they are linked to the wrong files. This pull request fixes it.

@MattSturgeon
Copy link
Member

MattSturgeon commented Aug 18, 2024

This looks like it's attempting to fix #1625, but unfortunately this won't fully solve the issue because those relative links aren't always resolved from the same place.

Essentially, the install page can be accessed via either / or /user-guide/install.html. It is usually accessed at the former location, however relative links are broken at the latter location.

All this PR does is flip the issue, so now links from the / location will be broken while links from /user-guide/install.html will work.

@HeitorAugustoLN
Copy link
Member Author

All this PR does is flip the issue, so now links from the / location will be broken while links from /user-guide/install.html will work.

Indeed, you are correct. I had not previously noticed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants