Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed duplicate "/tmp/disk-1.key /tmp/disk-1.key" #281

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

we-do-it-lu
Copy link
Contributor

No description provided.

@Mic92 Mic92 merged commit 06e70b3 into nix-community:main Feb 21, 2024
23 checks passed
@scvalex
Copy link

scvalex commented Feb 25, 2024

Isn't this change actually wrong?

The docs say both <remote_path> and <local_path> are necessary.

* --disk-encryption-keys <remote_path> <local_path>
  copy the contents of the file or pipe in local_path to remote_path in the installer environment,
  after kexec but before installation. Can be repeated.

The code also doesn't seem to have any support for eliding the second path if it's identical:

--disk-encryption-keys)

@Mic92
Copy link
Member

Mic92 commented Mar 14, 2024

Yeah it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants