nixd/lspserver: fix high cpu on fd polling #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inclyc
approved these changes
Dec 17, 2024
|
looks like it tries to compile with llvm-18 and not llvm-16 (as defined in the flake) |
Yes I think that's the problem. However I didn't push any commit before your PR, and previously it was correct, don't know why meson uses llvm-18. |
inclyc
force-pushed
the
fix-fd-pollhub
branch
from
10505ff to
c8860d6
Compare
|
I think it is caused by the upgrading to ubuntu 24.04 by github. So I fixed the runner version tag, and rebased your branch. |
|
Wait, this commit triggers CI error after merged: regression/nixd TIMEOUT 60.16s killed by signal 15 SIGTERM I think it is caused by a slow runner on github, sigh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #627