Follow-up of #167 #231
Merged
Follow-up of #167 #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of unpacking all crates in a git dep, this only unpacks the crates specified in the cargo lock file.
nmattia
approved these changes
Apr 4, 2022
jwoudenberg
added a commit
to jwoudenberg/elm-pair
that referenced
this pull request
Apr 6, 2022
We were using a fork to get support for gitlinks in the patch section of a Cargo.toml file. The PR that introduced support for this and more has recently been merged, see: nix-community/naersk#231
This was referenced Apr 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've addressed @blitz's comments (in the appropriate threads in the previous PR), and, compared to the base pull request, this one introduces two additional changes:
allRefshas been renamed intogitAllRefs(to keep consistency withgitSubmodules),READMEhas been updated.