Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: skip invalid manifests #220

Closed

Conversation

FlorianFranzen
Copy link
Contributor

This patch makes sure that only crates that pass some rudimentary check are unpacked in git-deps. This avoids git repos with random and/or broken Cargo.toml files to break your whole build.

The proper fix would be to unpack needed dependencies, but that is a bit more involved, so this should offer a quick and simple fix for now.

@jonringer
Copy link

jonringer commented Jan 7, 2022

Wouldn't it be preferable to just fix the toml file?

This avoids git repos with random and/or broken Cargo.toml files to break your whole build.

Nevermind, just re-read this. Makes sense.

@FlorianFranzen
Copy link
Contributor Author

@jonringer I patched this even more by only installing the dependencies request (see here) in which case this would be no longer needed, but I thought this is a good quick fix.

@Patryk27
Copy link
Contributor

Hi, thanks for this merge request; as far as I understand, #167 already solves it, right? (unless there's some additional depth to cargo verify-project that I don't see 🙂)

So in the effort of cleaning-up issues in this repository, I'll just go ahead and close this merge request - but if you feel we could use cargo verify-project, please feel free to re-open it 🙂

Thanks again!

@Patryk27 Patryk27 closed this Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants