Add test git-dep-with-submodule #111
Conversation
Signed-off-by: Ana Hobden <operator@hoverbear.org>
| @@ -121,6 +121,12 @@ let | |||
| cargoOptions = (opts: opts ++ [ "--locked" ]); | |||
| }; | |||
|
|
|||
| git-dep-with-submodule = naersk.buildPackage { | |||
| doCheck = true; | |||
| src = ./test/git-dep-with-submodule; | |||
There was a problem hiding this comment.
I think you forgot to check in the testcase itself.
$ nix build -f test.nix git-dep-with-submodule
error: opening file '/home/vin/workspace/vcs/naersk/test/git-dep-with-submodule/Cargo.toml': No such file or directory
(use '--show-trace' to show detailed location information)
There was a problem hiding this comment.
Yup I did! 🤦♀️
Good news is this new commit includes a fix!
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Hoverbear
changed the title
Hoverbear
changed the title
|
So I included a ... partial fix? I'm not sure. I don't think moving to |
| @@ -1,4 +1,4 @@ | |||
| { lib, writeText, runCommand, remarshal }: | |||
| { lib, writeText, runCommand, remarshal, fetchgit }: | |||
There was a problem hiding this comment.
is fetchgit actually used?
There was a problem hiding this comment.
So I actually got stuck here, since fetchgit requires sha256 and as far as I can tell we don't have that! The builtins.fetchGit doesn't, but it's not due for release until Nix 2.4 (Domen told me!)
I could use your guidance or assistance. :)
|
I don't have a working solution to this so I'll close and leave the report open. :) |
|
Hey! I couldn't give this more attention, I have a lot on my plate at the moment. I'll try to look #110 as soon as possible. In the meantime, thanks for giving this a shot! |
|
I think we all do right now. :) Keep up your really amazing work @nmattia ! Thanks for looking at this! |
A reproduction test and working on a fix for #110.
Reproduce with