Fix various issues #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the backslash character literal parsing code may be wrong. I'm not sure how it's supposed to work. |
|
Thanks for doing this! Can you also update this to |
|
OK done |
|
Sorry, I don't know anything about cachix. Does this work in master? |
|
Need to bump the version of all actions to the latest, as this project hasn't seen an update in a while. |
|
OK, I think you'll have to do that? |
|
You can do it on this PR in the same way you updated the |
|
The CI is broken in master, is it not? Fix it in master and then I'll merge it in. |
|
Opened CI fix pr #81 |
jtojnar
reviewed
Jun 19, 2023
gvolpe
approved these changes
Jun 22, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There might still be output issues.