Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repoOverrides #101

Closed
wants to merge 1 commit into from
Closed

Add repoOverrides #101

wants to merge 1 commit into from

Conversation

bb010g
Copy link
Contributor

@bb010g bb010g commented Dec 19, 2018

Includes my NUR repo, the neXromancers NUR repo, and an argument to allow for overrides of repos on invocation. Pretty straightforward, and here's how I used it to work on packaging these smoothly:

repoOverrides = {
  bb010g = { type = "path"; url = ~/nix/nur-bb010g; };
  nexromancers = { type = "path"; url = ~/nix/nur-nexromancers; };
}

Yes, you could do this by symlinking in directories to the proper places in <NUR/repos>, but this feels a lot more idiomatic to me, also supports testing non-local repositories, and does not require a local NUR clone.

  • I ran nur/format-manifest.py after updating repos.json (We will use the same script in travis ci to make sure we keep the format consistent)
  • By including this repository in NUR I give permission to license the
    content under the MIT license.

@bb010g bb010g requested a review from infinisil as a code owner December 19, 2018 12:46
@Mic92
Copy link
Member

Mic92 commented Dec 19, 2018

The license in hacksaw is incorrect: https://travis-ci.com/nix-community/NUR/builds/95325314#L760

@bb010g
Copy link
Contributor Author

bb010g commented Dec 20, 2018

Fixed.

@Mic92
Copy link
Member

Mic92 commented Dec 20, 2018

I cherry-picked your repositories to master
I want to have a closer look at repoOverrides soonish

[master 24262da] Add neXromancers repo
Author: Brayden Banks me@bb010g.com
Date: Wed Dec 19 04:34:23 2018 -0800
1 file changed, 3 insertions(+)
[master 3502bc5] Add bb010g repo
Author: Brayden Banks me@bb010g.com
Date: Wed Dec 19 04:34:36 2018 -0800
1 file changed, 3 insertions(+)

@bb010g
Copy link
Contributor Author

bb010g commented Dec 21, 2018

Sounds good. Simplified this down to just the one commit.

@bb010g
Copy link
Contributor Author

bb010g commented Jan 6, 2019

Bump?

@bb010g bb010g changed the title Add bb010g & neXromancers repos and repoOverrides Add repoOverrides Jan 14, 2019
@danbst
Copy link

danbst commented Jan 21, 2019

@bb010g see #111
Just install NUR as an overlay and add override overlay:

self: super: {
  nur = super.nur // {
    repos = super.nur.repos // {
      bb010g = import ~/nix/nur-bb010g self;
      nexromancers = import ~/nix/nur-nexromancers self;
    };
  };
}

Just make sure this overlay is loaded after NUR one, then all overrides will work correctly.

@Mic92
Copy link
Member

Mic92 commented Jan 22, 2019

@danbst right, but this looks complex an easier way as proposed by @bb010g is still worth pursuing.

@danbst
Copy link

danbst commented Jan 22, 2019

I hope NixOS/nixpkgs#54266 will get more love, then NUR as overlay will allow this:

self: super: {
  nur.repos.bb010g = import ~/nix/nur-bb010g self;
  nur.repos.nexromancers = import ~/nix/nur-nexromancers self;

  # in case we want to replace bit-by-bit, including removals
  nur.repos._merge.bb010g = false;
  nur.repos._merge.nexromancers = false;
}

I'm not opposing to PR, just proposed another way to solve the problem (without "symlinking in directories to the proper places in <NUR/repos>")

@bb010g
Copy link
Contributor Author

bb010g commented Jan 22, 2019

This allows you to continue using packageOverrides nicely, which is the recommended NUR installation method.

@Mic92 Mic92 mentioned this pull request Jan 22, 2019
@Mic92
Copy link
Member

Mic92 commented Jan 22, 2019

@bb010g can you take a look at: #112
?

@Mic92
Copy link
Member

Mic92 commented Jan 28, 2019

Thanks! Feature got merged with #112

@Mic92 Mic92 closed this Jan 28, 2019
@bb010g bb010g deleted the yay-nur branch June 1, 2019 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants