Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HapticKey blocks Notification Centre Gesture (two fingers) on the Trackpad MB2019 16" #36

Closed
hackToxa opened this issue Mar 10, 2020 · 9 comments
Labels

Comments

@hackToxa
Copy link

Hi,

I really like HapticKey.
Unfortunately, on my new MB 2019 16", I noticed it is blocking the Notification Gesture.

Only per google search, I found a relation and after switching HapticKey of, it works again.
Seems to be a bug.

BR

@niw
Copy link
Owner

niw commented Mar 10, 2020

Hi, @hackToxa, thank you for reporting.

I tested on my MacBook Pro (2017) and the notification center gesture, two finger swiping from right outside of track pad to inside of track pad works while HapticKey.app is running and enabled, however, I observed the gesture stops working after quitting HapticKey.app or some similar operations such as the application launching or quitting.

Are you seeing similar behavior on your environment as well?

I will investigate it closely this behavior later.

@niw niw added the bug label Mar 10, 2020
@Vxider
Copy link

Vxider commented Mar 13, 2020

@niw I have a 16 inch MBP(2019), same with you, notification center gesture works well when using HapicKey, but stop working after quitting. I encountered this problem before using HapicKey(notification center and zoom in/out gesture). I even write a applescript to reset the touchpad options in System Preferences.

@elblan
Copy link

elblan commented Mar 13, 2020

16inch MBP here too, not having any issues so far

@niw
Copy link
Owner

niw commented Mar 15, 2020

Currently I found possible race condition of how HapticKey is handling gesture events and how application quits since most of case HapticKey quits by menu item “Quit HapticKey” however, selecting that menu item is actually gesture and seems like that causes some timing problem and messed CGEventTap, which HapticKey is using to detect taps on Touch Bar.

Current workaround is quitting HapticKey (if neeeded,) use ⌘Q short-cut key while menu is open, or use Activity Monitor to quit it.
Another workaround is not using “All Taps on Touch Bar” but use “ESC and F1, F2, etc. Keys”.
I understand that's not enough in some specific usage case, that might be enough.

At this moment, I do not have a solution yet. However, I keep investigate the possible solution for this.

@niw
Copy link
Owner

niw commented Mar 22, 2020

I think d2aec16 may fix this issue. Testing now.

@niw
Copy link
Owner

niw commented Mar 22, 2020

Hi, @hackToxa, @Vxider and @etienneleblan!

I made a binary from the latest branch for testing before releasing.
HapticKey.app-20200322210145.zip

This should fix the issue mentioned here, also hopefully it is handling the taps in better way.
If you have a time, please test it and let me know if you find any problems.

Thank you!

@Vxider
Copy link

Vxider commented Mar 23, 2020

Thanks for your work, 20200322210145 works well for my 16 inch MBP(2019).

@niw
Copy link
Owner

niw commented Mar 23, 2020

@Vxider Thank you for testing!

niw added a commit that referenced this issue Mar 23, 2020
* Bug fix: Notification center swipe gesture stops working. (#36)
* Update Japanese localization format. (#32)
* Update traditional Chinese localization.
* Add "About" panel.
* Internal beauty.
@niw
Copy link
Owner

niw commented Mar 23, 2020

Released 0.5.0.
https://github.com/niw/HapticKey/releases/tag/0.5.0

Thank you for your help!

@niw niw closed this as completed Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants