refactor(frontend): shared data params state #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Setting this to draft because it should fail CI in its current state. It's missing a mechanism for passing app config into the shared lib state, without statically importing the config directly from |
eatyourgreens
force-pushed
the
refactor-data-params-state
branch
10 times, most recently
from
906b364 to
d4102fb
Compare
Move generic data params state into `src/lib`. The aim here is that the app should be responsible for loading data params config, but the shared `lib` package should be responsible for handling data params state and updating the map.
eatyourgreens
force-pushed
the
refactor-data-params-state
branch
from
d4102fb to
c9fced0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move generic data params state into
src/lib. The aim here is that the app should be responsible for loading data params config, but the sharedlibpackage should be responsible for handling data params state and updating the map.