FIX/TEST: Numpy casting rules have gotten more strict, raise different exception #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #768 +/- ##
=========================================
Coverage ? 88.38%
=========================================
Files ? 188
Lines ? 24008
Branches ? 4254
=========================================
Hits ? 21219
Misses ? 2103
Partials ? 686Continue to review full report at Codecov.
|
effigies
force-pushed
the
fix/numpy_casting_error
branch
from
481897e to
86b4fbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-tests breaking on numpy 1.17-dev, probably resulting from numpy/numpy#13648.
I don't see any obvious behavioral changes for nibabel users here, just adapting a test to new numpy constraints.
Reviews welcome, otherwise plan to merge in 1 week.