Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Purge defunct nisext package #1290

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Conversation

effigies
Copy link
Member

@effigies effigies commented Dec 26, 2023

It's time.

Deprecated in #1170, with removal scheduled for 6.0.

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1436a6e) 92.23% compared to head (cff32bb) 92.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1290   +/-   ##
=======================================
  Coverage   92.23%   92.23%           
=======================================
  Files          99       99           
  Lines       12461    12461           
  Branches     2562     2562           
=======================================
  Hits        11494    11494           
  Misses        643      643           
  Partials      324      324           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@matthew-brett matthew-brett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@effigies effigies merged commit 5d884bd into nipy:master Dec 26, 2023
52 checks passed
@effigies effigies deleted the purge-nisext branch October 8, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants