TYP: Annotate SpatialImage accepting affine=None

[blakedewey]

This corrects the typing for the SpatialImage __init__ function by allowing None for affine.

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1843355) 92.16% compared to head (21113e3) 92.16%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1253   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files          98       98           
  Lines       12370    12371    +1     
  Branches     2542     2542           
=======================================
+ Hits        11401    11402    +1     
  Misses        646      646           
  Partials      323      323           

Files Changed	Coverage Δ
nibabel/spatialimages.py	94.11% <100.00%> (+0.02%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[effigies]

Reading the mypy failure, I think we need to add an assert self._affine is not None before line 569.

[effigies]

Looking good. If you pip install this version into your pycharm environment, does it resolve your Nifti1Image(data, None, header) issue?

[blakedewey]

Yes! It does.

[effigies]

Great! Thanks for reporting and fixing the issue!