FIX: Catch random bad slice when testing image slicing #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1221 +/- ##
=======================================
Coverage 92.16% 92.16%
=======================================
Files 98 98
Lines 12372 12372
Branches 2543 2543
=======================================
Hits 11403 11403
Misses 646 646
Partials 323 323 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an apparent Heisenbug that would occasionally cause Windows tests to fail on Python 3.10.
After booting up a Windows machine and running ~30k tests with different
PYTHONHASHSEEDs, it turns out it's a regular old bug based on a random selection that has nothing to do with Windows and Python 3.10. If the dimensionality of the sliced dataobj (can go up withNones) exceeds 7, Analyze-like images can't represent it.