FIX: Version comparison on alert_future_error

nipy · Jan 9, 2023 · 5f37ffa · 5f37ffa
1 parent 4180847
commit 5f37ffa
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/nibabel/deprecated.py b/nibabel/deprecated.py
@@ -111,7 +111,7 @@ def alert_future_error(
         Warnings stacklevel to provide; note that this will be incremented by
         1, so provide the stacklevel you would provide directly to warnings.warn()
     """
-    if cmp_pkg_version(version) >= 0:
+    if cmp_pkg_version(version) > 0:
         msg = f'{msg} This will error in NiBabel {version}. {warning_rec}'
         warnings.warn(msg.strip(), warning_class, stacklevel=stacklevel + 1)
     else:

diff --git a/nibabel/tests/test_deprecated.py b/nibabel/tests/test_deprecated.py
@@ -109,3 +109,11 @@ def test_alert_future_error():
             error_rec='Fix this issue by doing XYZ.',
             error_class=ValueError,
         )
+    with pytest.raises(ValueError):
+        alert_future_error(
+            'Message',
+            '2.0.0',  # Error if we equal the (patched) version
+            warning_rec='Silence this warning by doing XYZ.',
+            error_rec='Fix this issue by doing XYZ.',
+            error_class=ValueError,
+        )