Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend calibrated calibrations tests and fix bugs; restore part of inspector calibration code. #1214

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

cmeyer
Copy link
Collaborator

@cmeyer cmeyer commented Oct 15, 2024

Please review. This is part of the SVG changes.

Reverted part of the previous attempt in the inspector since the inspector
has special code dealing with changes that this new class does not support.
The version of these classes in the inspector is directly dependent on the
calibration style, while these new classes are not.
Copy link
Contributor

@lisham2000 lisham2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good for the change in calibration string when only one dimension is calibrated. Approved from me and will rebase into my PR when merged

@cmeyer cmeyer merged commit 5f750bd into nion-software:master Oct 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants