Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #983. Bypass panel multi-select when only shift and tool utilizes shift. #1130

Merged

Conversation

cmeyer
Copy link
Collaborator

@cmeyer cmeyer commented Aug 9, 2024

No description provided.

Copy link
Contributor

@Tiomat85 Tiomat85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears to fix the initial problem with the shift key and Rectangle triggering both actions. It certainly seems better, but there look to have been a few extra niggles which could either end up with other Issues or just a weakness going forwards.
You can hold Ctrl with creating the rectangle, and it still selects after drawing the rectangle. That is less of a problem as it doesn't have a direct use, but it can still lead to strange UX behaviour where using a control can gain side-effects.

@cmeyer
Copy link
Collaborator Author

cmeyer commented Aug 12, 2024

If there are other problems, let's file issues. I like this PR solution because it is isolated to nionswift and fixes the problem. But I'd also like to either approve this PR and move on or reject it with a valid reason and a better solution.

@cmeyer cmeyer merged commit e29571c into nion-software:master Aug 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants