Fix older VS compatibility issues and PDB files generation issue.

[ikifof]

This fixes several windows builds related issue:

• the issue MSVC 12 bot broken after high-res timestamp change #1411 (with visual studio 2013 and earlier);
• another compilation issue with VS2012 (strtoll not defined)
• the PDB files related warnings when building ninja/ninja_test by providing a unique name per library/binary for the PDB file.

[jhasse]

Looks like you merge the changes? Can you do

git rebase origin/master
git push ikifof issue1411_MSVC12_broken --force

?

(I'm assuming that origin is https://github.com/ninja-build/ninja.git and ikifof is your fork)

[ikifof]

Did I do something wrong? I hope not... Git has some cool features... but way too uselessly complex... :(

I just ran the 2 commands you gave. I think I answered all your review comments but somehow the CR summary still shows an open request... Let me know if I need to do something.

Note that the MinGW build has some bad warnings and fails the disk_interface_test that was disabled for msvc only. It probably should be disabled on windows.

[jhasse]

What's your output of git remote -v?

the disk_interface_test that was disabled for msvc only. It probably should be disabled on windows.

Will do that tomorrow.

[ikifof]

origin https://github.com/ikifof/ninja.git (fetch)
origin https://github.com/ikifof/ninja.git (push)
upstream https://github.com/ninja-build/ninja.git (fetch)
upstream https://github.com/ninja-build/ninja.git (push)

[jhasse]

Ah! Run these then please:

git rebase upstream/master
git push origin issue1411_MSVC12_broken --force

[ikifof]

Let me know if I need to do anything else. I can create a new clean pull request if I made things complicated by messing up this one.

[jhasse]

No it's okay, I squashed the commits using GitHub. Thank you!

[ikifof]

Thanks!