Remove broken disk_interface test for Stat

[atetubou]

We don't want to pass non-canonicalized path to DiskInterface::Stat.

This makes test pass on appveyor.

[jhasse]

Thanks for the PR, we definitely need to fix that AppVeyor build. Can you elaborate what's the problem with non-canonicalized paths?

[ikifof]

Ninja relies on the path being canonicalized: so it does not seem to make sense to test the behavior of utility functions in ninja core on non-canonicalized path, mainly if some platforms do not properly support some non-canonicalize paths (see #1420 ).
If we make the assumption that all paths that reach this point are canonicalized, should we assert if we get one that is not? (although that will probably make a lot of the tests to fail).

Edit: somehow a simple change that worked yesterday does not seem to actually work... so removing it from this comment. It seems it make sense to get rid of this test as far as this function is only used in the scope of ninja which only works on canonicalized path.

[jhasse]

If we make the assumption that all paths that reach this point are canonicalized, should we assert if we get one that is not?

Yes, sounds like a good idea to me.

(although that will probably make a lot of the tests to fail).

Shouldn't they already fail on Windows then?

[atetubou]

Sorry, I cannot make a time to invest for this near future. So please feel free to take this if someone interested in this.

[jhasse]

No problem. Thanks for the PR and the explanation, I will take a closer look (deactivated the tests for now).