Allow output to be modified with -O #1027
Closed
+123
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the "smart terminal" configuration into three separate settings: color, elide, and reprint. Allow setting these options individually or in bulk through a new -O option. To have build output into a dumb terminal still include ANSI color codes, for example if you wanted to pass continuous build output through ansi2html, use: ninja -O color To force smart terminal output, use: ninja -O smart To force smart terminal output, but still print full status descriptions: ninja -O smart -O noelide Addresses some of the issues in ninja-build#746 while allowing for adding more output options in the future.
Fixes -O reprint -O noelide on linux, and splits elide and reprint on windows (untested).
|
@martine Evan, did you consider this? Is it fine to you or have you rejected it? |
|
@nico is in charge now. :) |
|
This is related to pull request #1230 |
This is now possible using
On Linux (don't know about other unixes or Windows), this can be done using
I think #1210 is the way forward here. In order to reduce the number of open PRs I'm closing this one, hope that's okay with you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the "smart terminal" configuration into three separate settings:
color, elide, and reprint. Allow setting these options individually or
in bulk through a new -O option.
To have build output into a dumb terminal still include ANSI color
codes, for example if you wanted to pass continuous build output through
ansi2html, use:
ninja -O color
To force smart terminal output, use:
ninja -O smart
To force smart terminal output, but still print full status
descriptions:
ninja -O smart -O noelide
Addresses some of the issues in #746 while allowing for adding more
output options in the future.