fixed the piece weigth generator using a correct random.NextFloat

ninetailsrabbit · Jun 7, 2024 · a3b17ed · a3b17ed
1 parent 49158d0
commit a3b17ed
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/Match3Maker/Match3Maker.csproj b/Match3Maker/Match3Maker.csproj
@@ -14,7 +14,7 @@
 
 	<PropertyGroup>
 		<Title>Ninetailsrabbit.Match3Maker</Title>
-		<Version>1.0.7</Version>
+		<Version>1.0.8</Version>
 		<Description>This lightweight library provides the core logic and functionality you need to build engaging match-3 games. Focus on game design and mechanics while leaving the complex logic to this library</Description>
 		<Copyright>© 2024 Ninetailsrabbit</Copyright>
 		<Authors>Ninetailsrabbit</Authors>

diff --git a/Match3Maker/src/extensions/RandomExtension.cs b/Match3Maker/src/extensions/RandomExtension.cs
@@ -18,14 +18,12 @@ public static class RandomExtension {
         /// 
         /// https://stackoverflow.com/questions/63650648/random-float-in-c-sharp
         /// </remarks>
-        public static float NextFloat(this Random random, float minValue = 0.000001f, float maxValue = 1f) {
-            float range = Math.Min(1, Math.Max(minValue, maxValue) - Math.Min(minValue, maxValue));
+        public static float NextFloat(this Random random, float minValue = float.MinValue, float maxValue = float.MaxValue) {
+            double range = (double)maxValue - (double)minValue;
+            double sample = random.NextDouble();
+            double scaled = (sample * range) + float.MinValue;
 
-            double mantissa = (random.NextDouble() * 2.0) - 1.0;
-            // choose -149 instead of -126 to also generate subnormal floats (*)
-            double exponent = Math.Pow(2.0, random.Next(-126, 128));
-
-            return (float)(mantissa * exponent) * range;
+            return (float)scaled;
         }
 
     }