fix: allow node apps to also override webroot #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for node apps the webroot was hardcoded to `build` (since it's the react default). Some other frameworks might use a different path to store the build artifacts, so we want to allow the user to override it.
ctrox
force-pushed
the
node-webroot-override
branch
from
3d73ff6
to
77a3030
Compare
pawelkuc
reviewed
Apr 23, 2024
pawelkuc
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for node apps the webroot was hardcoded to
build(since it's the react default). Some other frameworks might use a different path to store the build artifacts, so we want to allow the user to override it.