Second mempool, small refactoring #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All logic remains unchanged, this commit only moves code around.
Codecov Report
@@ Coverage Diff @@
## viquezcl/second_mempool #929 +/- ##
===========================================================
- Coverage 64.31% 64.24% -0.08%
===========================================================
Files 357 359 +2
Lines 42329 42257 -72
===========================================================
- Hits 27222 27146 -76
- Misses 15107 15111 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
viquezclaudio
pushed a commit
that referenced
this pull request
Jul 11, 2022
* Move some structs to their own modules All logic remains unchanged, this commit only moves code around. * Only use a single MempoolExecutor by using generic Topic * Add private fn start_executor and reuse where applicable * Move expired_transactions function to MempoolState
viquezclaudio
pushed a commit
that referenced
this pull request
Jul 11, 2022
* Move some structs to their own modules All logic remains unchanged, this commit only moves code around. * Only use a single MempoolExecutor by using generic Topic * Add private fn start_executor and reuse where applicable * Move expired_transactions function to MempoolState
viquezclaudio
pushed a commit
that referenced
this pull request
Jul 12, 2022
* Move some structs to their own modules All logic remains unchanged, this commit only moves code around. * Only use a single MempoolExecutor by using generic Topic * Add private fn start_executor and reuse where applicable * Move expired_transactions function to MempoolState
viquezclaudio
pushed a commit
that referenced
this pull request
Jul 13, 2022
* Move some structs to their own modules All logic remains unchanged, this commit only moves code around. * Only use a single MempoolExecutor by using generic Topic * Add private fn start_executor and reuse where applicable * Move expired_transactions function to MempoolState
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MempoolStateandMempoolTransactionsalongside their additional types to their own filesMempoolExecutorandControlMempoolExecutorinto a singleMempoolExecutorstruct that is instantiated two timesThe first commit moving the code does not change any logic for an easier reviewing process.