Do the locking around Validator state instead of on each member
#3163
+166
−180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrxi
commented
Nov 27, 2024
| info!("Initializing validator {}", validator.validator_address()); | ||
| info!( | ||
| "Initializing validator {}", | ||
| validator.state().read().validator_address |
There was a problem hiding this comment.
Suggested change
| validator.state().read().validator_address | |
| validator.state().validator_address() |
This read() is maybe not so nice, should I encapsulate that?
There was a problem hiding this comment.
I do not mind the .read() here all that much, so from my end a change would not be necessary.
|
Can you add an explanation of why to the PR? |
hrxi
force-pushed
the
hrxi/validator_state
branch
from
9e0e58e to
fbc8d13
Compare
nibhar
approved these changes
Nov 28, 2024
| info!("Initializing validator {}", validator.validator_address()); | ||
| info!( | ||
| "Initializing validator {}", | ||
| validator.state().read().validator_address |
There was a problem hiding this comment.
I do not mind the .read() here all that much, so from my end a change would not be necessary.
| consensus_state: Arc<RwLock<ConsensusState>>, | ||
| validator_state: Option<InactivityState>, | ||
| automatic_reactivate: Arc<AtomicBool>, | ||
|
|
||
| macro_producer: Option<ProduceMacroBlock<TValidatorNetwork>>, | ||
| macro_state: Arc<RwLock<Option<MacroState>>>, |
There was a problem hiding this comment.
This could be added to the ValidatorState. Additionally that would open up a Rpc call to see the macro state which could be a very useful debugging tool.
hrxi
force-pushed
the
hrxi/validator_state
branch
from
fbc8d13 to
a977a14
Compare
Eligioo
reviewed
Jan 30, 2025
| } | ||
|
|
||
| // TODO: why do we give out secret keys via RPC? |
There was a problem hiding this comment.
Added an issue: #3270.
Theoretically a breaking change so I didn't want to do it here.
hrxi
force-pushed
the
hrxi/validator_state
branch
from
a977a14 to
c80d3c5
Compare
This makes it easier to add new members, also, the individual locking did not really make sense because these shouldn't go out of sync.
hrxi
force-pushed
the
hrxi/validator_state
branch
from
c80d3c5 to
30781f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to add new members, also, the individual locking did not really make sense because these shouldn't go out of sync.