Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockQueue: accept block announcements from any connected peer #2982

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

styppo
Copy link
Member

@styppo styppo commented Oct 16, 2024

No description provided.

Copy link
Member

@ii-cruz ii-cruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@nibhar nibhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this supersedes #2889 I think as stated in that PR the macro_head_hash should remain in the response.

@styppo styppo added the testnet-restart Change breaks the protocol and requires a testnet restart label Oct 17, 2024
@styppo
Copy link
Member Author

styppo commented Oct 17, 2024

Added macro and election head hash to the response in c064cc1.

Copy link
Member

@nibhar nibhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create an Issue to track utilizing the macro_heads.

@jsdanielh jsdanielh merged commit c064cc1 into albatross Oct 17, 2024
23 checks passed
@jsdanielh jsdanielh deleted the styppo/live-sync branch October 17, 2024 14:33
@jsdanielh jsdanielh added this to the Nimiq PoS Mainnet milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testnet-restart Change breaks the protocol and requires a testnet restart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants