Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The reactivate state would not get reset in case of rebranch. #2919

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

ii-cruz
Copy link
Member

@ii-cruz ii-cruz commented Sep 17, 2024

What's in this pull request?

The inactivity validator state would not get reset if the block of the validity window termination was from a rebranch event.

Pull request checklist

  • All tests pass. The project builds and runs.
  • I have resolved any merge conflicts.
  • I have resolved all clippy and rustfmt warnings.

@ii-cruz ii-cruz added the bug Something isn't working label Sep 17, 2024
@ii-cruz ii-cruz added this to the Nimiq PoS Mainnet milestone Sep 17, 2024
@ii-cruz ii-cruz self-assigned this Sep 17, 2024
@ii-cruz ii-cruz force-pushed the iicruz/automatic-reactivate-fix branch from c6d5822 to 6f75fef Compare September 19, 2024 11:22
Copy link
Member

@hrxi hrxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hrxi hrxi force-pushed the iicruz/automatic-reactivate-fix branch from 6f75fef to 8352415 Compare September 19, 2024 13:36
@hrxi
Copy link
Member

hrxi commented Sep 19, 2024

Rebased for merging.

@hrxi hrxi force-pushed the iicruz/automatic-reactivate-fix branch from d076dd2 to 8352415 Compare September 19, 2024 13:42
@jsdanielh jsdanielh merged commit 8352415 into albatross Sep 19, 2024
13 checks passed
@jsdanielh jsdanielh deleted the iicruz/automatic-reactivate-fix branch September 19, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants