consensus: Improve error handling for failed missing block requests #2886
+41
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdanielh
force-pushed
the
jsdanielh/fix
branch
3 times, most recently
from
11e2444
to
eca631c
Compare
ii-cruz
requested changes
Sep 6, 2024
jsdanielh
force-pushed
the
jsdanielh/fix
branch
from
eca631c
to
82d5bf2
Compare
ii-cruz
reviewed
Sep 9, 2024
Eligioo
approved these changes
Sep 10, 2024
jsdanielh
force-pushed
the
jsdanielh/fix
branch
from
82d5bf2
to
2d74059
Compare
@viquezclaudio fixed them in |
jsdanielh
force-pushed
the
jsdanielh/fix
branch
from
2d74059
to
afaa573
Compare
ii-cruz
approved these changes
Sep 20, 2024
Improve error handling for failed missing block requests in the block queue by removing from the buffer the block successor chain if a request for a missing block failed.
jsdanielh
force-pushed
the
jsdanielh/fix
branch
from
afaa573
to
d9bb281
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error handling for failed missing block requests in the block queue by removing from the buffer the block successor chain if a request for a missing block failed.
Pull request checklist
clippyandrustfmtwarnings.