Various WASM client updates #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## albatross #1489 +/- ##
=============================================
- Coverage 65.28% 64.95% -0.33%
=============================================
Files 424 425 +1
Lines 52121 52376 +255
=============================================
- Hits 34027 34021 -6
- Misses 18094 18355 +261
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Rebasing it to get it merged |
To be consistent with 1.0 client and across all methods, as the upcoming add_transaction_listener method will have to be async.
Because the API is mostly async, two async methods of which one takes `&mut self` and the other takes `&self` cannot be called at the same time. This prevents adding event listeners while waiting for waitForConsensusEstablished for example.
…urned Even when no peers accepted the subscription.
jsdanielh
force-pushed
the
soeren/wasm-various
branch
from
25c1b25 to
81bb56d
Compare
sisou
added
the
pow-compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
PlainBlockgenerated Typescript types, which were invalid beforeasync, like they have been in the 1.0 client and to be consistent (because the tx listener method must be async as it does network requests to subscribe at peers)getAccountandgetAccountsmethods on the client (enabled by Create the accounts proof request #1408 & Allow to prove the non-existence of keys #1484)serializemethod to Address for compatibility&mut selfmethodsaddTransactionListenerfrom failing when called without peersThis relates to #1339.
Pull request checklist
clippyandrustfmtwarnings.