Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt arguments of getTransactionsByAddress to be 1.0-compatible #1430

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

sisou
Copy link
Member

@sisou sisou commented Mar 14, 2023

What's in this pull request?

These new arguments follow the same order, type, and name as the 1.0 client method arguments.

Additionally, they are also a nice feature to have to be able to filter by block height and known transactions, reducing the number of proofs requested from the network.

This PR has conflicts with #1425, so when either is merged, the other will need to be rebased and merge-conflicts solved.

This relates to #1339.

Pull request checklist

  • All tests pass. The project builds and runs.
  • I have resolved any merge conflicts.
  • I have resolved all clippy and rustfmt warnings.

@sisou sisou added the WASM label Mar 14, 2023
@sisou sisou self-assigned this Mar 14, 2023
@sisou sisou mentioned this pull request Mar 14, 2023
10 tasks
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06 ⚠️

Comparison is base (c805f81) 65.74% compared to head (8196d31) 65.68%.

Additional details and impacted files
@@              Coverage Diff              @@
##           albatross    #1430      +/-   ##
=============================================
- Coverage      65.74%   65.68%   -0.06%     
=============================================
  Files            411      411              
  Lines          52188    52216      +28     
=============================================
- Hits           34310    34299      -11     
- Misses         17878    17917      +39     
Flag Coverage Δ
unittests 65.68% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
consensus/src/consensus/consensus_proxy.rs 3.77% <0.00%> (-0.29%) ⬇️
web-client/src/lib.rs 0.24% <0.00%> (-0.02%) ⬇️
web-client/src/transaction.rs 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jsdanielh jsdanielh merged commit 8196d31 into albatross Mar 14, 2023
@jsdanielh jsdanielh deleted the soeren/wasm-get-transactions-args branch March 14, 2023 19:54
@jsdanielh jsdanielh added this to the Nimiq PoS Testnet milestone Aug 1, 2023
@sisou sisou added the pow-compatibility Changes that ensure components are compatible with the PoW JS implementation. label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pow-compatibility Changes that ensure components are compatible with the PoW JS implementation. WASM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants