Fixed generic inheritance dispatch #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saem
approved these changes
Oct 25, 2021
| @@ -1412,6 +1412,10 @@ proc typeRel(c: var TCandidate, f, aOrig: PType, | |||
| let origF = f | |||
| var f = if prev == nil: f else: prev | |||
|
|
|||
| if a.len > 0: | |||
| let skippedA = a.skipTypesOrNil({tyObject}) # Skips if it's inheriting from a generic | |||
There was a problem hiding this comment.
One day when we have options in the compiler life will be grand.
|
Could you add a few summary remarks as to what/why in the PR comment? Hoping to have a useful for commit history over time. |
alaviss
added a commit
to alaviss/nimskull
that referenced
this pull request
Apr 21, 2023
does app things --- <!-- Note: section break (`---`) onwards is not in CI merge commit --> ## Notes for Reviewers * leave additional context for reviewers * maybe specific requests or areas of focus <!-- Pull Request(PR) Help Before Merge Ensure: * title reads like a short changelog line entry * code includes tests and is documented * leave the source better than before, but split out big reformats See contributor (guide)[https://nim-works.github.io/nimskull/contributing.html] for details, especially if you're new to this project. Tips that make PRs easier: * for big/impactful changes, start with chat/discussions to refine ideas * refine the pull request message over time; don't have to nail it in one go * handle the single commit message requirement at the end of review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using inherited generics does not dispatch properly and just takes the generic's base. This properly dispatches on the generic types so procs can overide based of inherited parameters. Making the following work: