vm: improve aliasing of slots under ORC
#297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indirectly accessing `slots` via a `TStackFrame` pointer was done to work around `shallowCopy` not being available for `seq` with ORC. The shallow copy is now replicated with the `cursor` pragma, saving one pointer indirection
|
It's a good sign when we're seeing a few lines for a win. Bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indirectly accessing
slotsvia aTStackFramepointer was done towork around
shallowCopynot being available forseqwith ORC.The shallow copy is now replicated with the
cursorpragma, savingone pointer indirection
I ran the test suite with an ORC enabled compiler and there were no (VM related) failures. This change allows to get rid of
SlotStoragein the VM refactoring PR