test case for #9180 and re-enables the disabled tcompilerapi test #9181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of implementing more workaround, could you try to solve the root of this issue? #9068 |
can be done in a subsequent PR by me or someone else. I prefer incremental progress to no progress ;-) |
timotheecour
changed the title
timotheecour
changed the title
|
I think this would have been much better as two PRs. |
|
@dom96 would u accept:
|
|
You might as well keep it as-is now, since you've already created it. In the future consider creating two PRs. As far as accepting this: that's @Araq's turf. |
Araq
reviewed
Oct 9, 2018
Araq
reviewed
Oct 9, 2018
Araq
reviewed
Oct 9, 2018
timotheecour
force-pushed
the
pr_fix_9180
branch
from
4729a6f to
1b27d09
Compare
|
PTAL |
timotheecour
force-pushed
the
pr_fix_9180
branch
from
1b27d09 to
56606db
Compare
timotheecour
changed the title
krux02
pushed a commit
to krux02/Nim
that referenced
this pull request
Oct 15, 2018
…test (nim-lang#9181) * add findNimStdLibCompileTime and un-disable tcompilerapi test; add test case for nim-lang#9180 * address comments
narimiran
pushed a commit
to narimiran/Nim
that referenced
this pull request
Oct 31, 2018
…test (nim-lang#9181) * add findNimStdLibCompileTime and un-disable tcompilerapi test; add test case for nim-lang#9180 * address comments
This was referenced Nov 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @Araq
Error: internal error: n is not nil#9180"effectively disable this test as 'nim' is not in the PATH so tcompilerapi cannot find Nim's standard library"
findNimStdLibCompileTimeError: internal error: n is not nil#9180Note: #9184 is still an issue after this PR (no change before / after this PR regarding that issue)