fix #8485 ; make default public instead of redefined everywhere; use better implementation
#8490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
timotheecour
commented
Jul 31, 2018
•
timotheecour
commented
- fixes #8485
metagn
reviewed
Aug 1, 2018
lib/system.nim
Outdated
| # needed pending https://github.com/nim-lang/Nim/issues/8486 | ||
| proc defaultImpl[T]():T= | ||
| var a: T | ||
| return a |
timotheecour
force-pushed
the
pr_default
branch
2 times, most recently
from
234aecc to
cae1f84
Compare
…e better implementation
timotheecour
force-pushed
the
pr_default
branch
from
cae1f84 to
809d6cc
Compare
|
@Araq PTAL tests green |
|
Yeah but I don't like this workaround sorry, let's wait for #8486 to be fixed please. |
|
This needs to be a language builtin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.