fixes #24623; fixes #23692; size pragma only allowed for imported types and enum types #24640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ringabout
changed the title
ringabout
changed the title
ringabout
changed the title
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
narimiran
pushed a commit
that referenced
this pull request
Jan 24, 2025
…es and enum types (#24640) fixes #24623 fixes #23692 ref https://nim-lang.org/docs/manual.html#implementation-specific-pragmas-size-pragma confines `size` pragma to `enums` and imported `objects` for now The `typeDefLeftSidePass` carries out the check for pragmas, but the type is not complete yet. So the `size` pragma checking is postponed at the final pass. (cherry picked from commit d6d28a9)
narimiran
pushed a commit
that referenced
this pull request
Jan 24, 2025
…es and enum types (#24640) fixes #24623 fixes #23692 ref https://nim-lang.org/docs/manual.html#implementation-specific-pragmas-size-pragma confines `size` pragma to `enums` and imported `objects` for now The `typeDefLeftSidePass` carries out the check for pragmas, but the type is not complete yet. So the `size` pragma checking is postponed at the final pass. (cherry picked from commit d6d28a9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #24623
fixes #23692
ref https://nim-lang.org/docs/manual.html#implementation-specific-pragmas-size-pragma
confines
sizepragma toenumsand importedobjectsfor nowThe
typeDefLeftSidePasscarries out the check for pragmas, but the type is not complete yet. So thesizepragma checking is postponed at the final pass.