Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test more Status' packages, refs #24266 #24275

Merged
merged 2 commits into from
Oct 11, 2024
Merged

test more Status' packages, refs #24266 #24275

merged 2 commits into from
Oct 11, 2024

Conversation

narimiran
Copy link
Member

This adds several new Status packages to the CIs:

  • confutils
  • eth
  • metrics
  • nat_traversal
  • toml_serialization

Other packages mentioned in #24266 are currently not ready to test with devel for various reasons.


This also enables criterion, and removes other packages that had been in the allowFailure category — even without them we have plenty of packages (145) that we test, there's no point in spending CI time on them just to see them fail every time.
If/when the authors of those packages make them work with Nim devel, we can re-introduce them then.

@narimiran narimiran merged commit 2747626 into devel Oct 11, 2024
16 checks passed
@narimiran narimiran deleted the add-more-packages branch October 11, 2024 06:46
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 2747626

Hint: mm: orc; opt: speed; options: -d:release
175090 lines; 8.244s; 655.133MiB peakmem

narimiran added a commit that referenced this pull request Oct 11, 2024
This adds several new Status packages to the CIs:

- confutils
- eth
- metrics
- nat_traversal
- toml_serialization

Other packages mentioned in #24266
are currently not ready to test with `devel` for various reasons.

----

This also enables `criterion`, and removes other packages that had been
in the `allowFailure` category — even without them we have plenty of
packages (145) that we test, there's no point in spending CI time on
them just to see them fail every time.
If/when the authors of those packages make them work with Nim devel, we
can re-introduce them then.

(cherry picked from commit 2747626)
narimiran added a commit that referenced this pull request Oct 11, 2024
This adds several new Status packages to the CIs:

- confutils
- eth
- metrics
- nat_traversal
- toml_serialization

Other packages mentioned in #24266
are currently not ready to test with `devel` for various reasons.

----

This also enables `criterion`, and removes other packages that had been
in the `allowFailure` category — even without them we have plenty of
packages (145) that we test, there's no point in spending CI time on
them just to see them fail every time.
If/when the authors of those packages make them work with Nim devel, we
can re-introduce them then.

(cherry picked from commit 2747626)
narimiran added a commit that referenced this pull request Jan 14, 2025
This adds several new Status packages to the CIs:

- confutils
- eth
- metrics
- nat_traversal
- toml_serialization

Other packages mentioned in #24266
are currently not ready to test with `devel` for various reasons.

----

This also enables `criterion`, and removes other packages that had been
in the `allowFailure` category — even without them we have plenty of
packages (145) that we test, there's no point in spending CI time on
them just to see them fail every time.
If/when the authors of those packages make them work with Nim devel, we
can re-introduce them then.

(cherry picked from commit 2747626)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant