math: Add cumprod and cumproded #23416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the inactivity on the PR, I've been away from Nim for the last few months. |
|
Reason for acceptance: We already have |
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
|
Thanks! |
narimiran
pushed a commit
that referenced
this pull request
Jan 15, 2025
This pull request adds the `cumproded` function along with its in-place equivalent, `cumprod`, to the math library. These functions provide functionality similar to `cumsum` and `cumsummed`, allowing users to calculate the cumulative sum of elements. The `cumprod` function computes the cumulative product of elements in-place, while `cumproded` additionally returns the prod seq. (cherry picked from commit 4aff124)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the
cumprodedfunction along with its in-place equivalent,cumprod, to the math library. These functions provide functionality similar tocumsumandcumsummed, allowing users to calculate the cumulative sum of elements.The
cumprodfunction computes the cumulative product of elements in-place, whilecumprodedadditionally returns the prod seq.