Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary side-effects from base64.encode(mime) #22986

Merged
merged 2 commits into from
Nov 25, 2023
Merged

remove unnecessary side-effects from base64.encode(mime) #22986

merged 2 commits into from
Nov 25, 2023

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Nov 25, 2023

Fixes #22985

@Araq Araq added the merge_when_passes_CI mergeable once green label Nov 25, 2023
@narimiran narimiran merged commit 26f2ea1 into nim-lang:devel Nov 25, 2023
19 checks passed
@narimiran
Copy link
Member

@tersec I guess you would like to see this backported to the 1.6 branch?

@github-actions GitHub Actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 26f2ea1

Hint: mm: orc; opt: speed; options: -d:release
176852 lines; 7.399s; 766.094MiB peakmem

@tersec
Copy link
Contributor Author

tersec commented Nov 25, 2023

@tersec I guess you would like to see this backported to the 1.6 branch?

Indeed

@tersec tersec deleted the base64-encode-no-side-effects branch November 25, 2023 20:03
narimiran pushed a commit that referenced this pull request Nov 26, 2023
@tersec @narimiran
remove unnecessary side-effects from base64.encode(mime) (#22986)
8834f3e 
Fixes #22985

(cherry picked from commit 26f2ea1)
narimiran pushed a commit that referenced this pull request Nov 26, 2023
@tersec @narimiran
remove unnecessary side-effects from base64.encode(mime) (#22986)
9cbd869 
Fixes #22985

(cherry picked from commit 26f2ea1)
@tersec tersec mentioned this pull request Jan 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merge_when_passes_CI mergeable once green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

base64.encode and base64.encodeMime have unnecessary side effects
3 participants
@tersec @narimiran @Araq