fixes #14917; Consider the case where nkBracket is of type tySequence
#22629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…passed through template.
metagn
reviewed
Sep 2, 2023
compiler/semexprs.nim
Outdated
| @@ -643,6 +643,15 @@ proc arrayConstrType(c: PContext, n: PNode): PType = | |||
| result = typ | |||
|
|
|||
| proc semArrayConstr(c: PContext, n: PNode, flags: TExprFlags; expectedType: PType = nil): PNode = | |||
| if n.typ != nil and n.typ.kind == tySequence: | |||
There was a problem hiding this comment.
Sorry if this is outside your comfort range, but could we maybe wait until the end and sem the array as normal and finally change the type to seq from the formed array type if the node was originally typed as seq? Just curious if it accomplishes the same thing.
|
This doesn't fix the root cause. |
|
I stumbled upon the same problem, just for the record: #20662 |
|
What is the root cause? Is the VM generating |
|
I don't know, but I do know that blindly reseming expressions is not a good solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14917