fix #20588 #21101
Closed
fix #20588 #21101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Dec 15, 2022
| @@ -3024,6 +3024,8 @@ proc semExpr(c: PContext, n: PNode, flags: TExprFlags = {}, expectedType: PType | |||
| of nkCall, nkInfix, nkPrefix, nkPostfix, nkCommand, nkCallStrLit: | |||
| # check if it is an expression macro: | |||
| checkMinSonsLen(n, 1, c.config) | |||
| if n[0].kind == nkIdent and n[0].ident.id == ord(wAuto): | |||
There was a problem hiding this comment.
You don't know at this point that auto was not redefined to be a proc overriding system.auto. Stop hacking special cases into the compiler. This a fix for semConv and it needs to check for more than just auto. For example untyped(4) or typed("abc) are likewise illegal constructs.
There was a problem hiding this comment.
wow,I debug into serveral places haven't found it goes to semConv, I'll create a fix in next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #20588
from my point of view
autois not suitable as function call