move cgi to nimble packages

changelog.md

@@ -109,6 +109,9 @@
 
 - Using an unnamed break in a block is deprecated. This warning will become an error in future versions! Use a named block with a named break instead.
 
+- Several Standard libraries are moved to nimble packages, use `nimble` to install them:
+  - move `std/cgi` to https://github.com/nim-lang/cgi
+
 ## Standard library additions and changes
 
 [//]: # "Changes:"

doc/lib.md

@@ -302,9 +302,6 @@ Internet Protocols and Support
 * [asyncstreams](asyncstreams.html)
   This module provides `FutureStream` - a future that acts as a queue.
 
-* [cgi](cgi.html)
-  This module implements helpers for CGI applications.
-
 * [cookies](cookies.html)
   This module contains helper procs for parsing and generating cookies.
 

tests/effects/tstrict_funcs_imports.nim

@@ -30,7 +30,6 @@ import
   base64,
   bitops,
   browsers,
-  cgi,
   chains,
   colors,
   complex,

tests/gc/growobjcrash.nim

@@ -1,9 +1,15 @@
-import std/[cgi, strtabs]
+import std/[uri, strtabs]
+
+iterator decodeData*(data: string): tuple[key, value: string] =
+  ## Reads and decodes CGI data and yields the (name, value) pairs the
+  ## data consists of.
+  for (key, value) in uri.decodeQuery(data):
+    yield (key, value)
 
 proc handleRequest(query: string): StringTableRef =
   iterator foo(): StringTableRef {.closure.} =
     var params = {:}.newStringTable()
-    for key, val in cgi.decodeData(query):
+    for key, val in decodeData(query):
       params[key] = val
     yield params
 

tests/js/tstdlib_imports.nim

@@ -45,7 +45,7 @@ import std/[
   # Internet protocols:
   cookies, httpcore, mimetypes, uri,
   # fails due to FFI: asyncdispatch, asyncfile, asyncftpclient, asynchttpserver,
-  # asyncnet, cgi, httpclient, nativesockets, net, selectors, smtp
+  # asyncnet, httpclient, nativesockets, net, selectors, smtp
   # works but no need to test: asyncstreams, asyncfutures
 
   # Threading:

tests/stdlib/tcgi.nim

@@ -1,27 +0,0 @@
-import std/unittest
-import std/[cgi, strtabs, sugar]
-import std/assertions
-
-block: # Test cgi module
-  const queryString = "foo=bar&фу=бар&checked=✓&list=1,2,3&with_space=text%20with%20space"
-
-  block: # test query parsing with readData
-    let parsedQuery = readData(queryString)
-
-    check parsedQuery["foo"] == "bar"
-    check parsedQuery["фу"] == "бар"
-    check parsedQuery["checked"] == "✓"
-    check parsedQuery["list"] == "1,2,3"
-    check parsedQuery["with_space"] == "text with space"
-
-    expect KeyError:
-      discard parsedQuery["not_existing_key"]
-
-# bug #15369
-let queryString = "a=1&b=0&c=3&d&e&a=5&a=t%20e%20x%20t&e=http%3A%2F%2Fw3schools.com%2Fmy%20test.asp%3Fname%3Dst%C3%A5le%26car%3Dsaab"
-
-doAssert collect(for pair in decodeData(queryString): pair) ==
-  @[("a", "1"), ("b", "0"), ("c", "3"),
-    ("d", ""),("e", ""), ("a", "5"), ("a", "t e x t"),
-  ("e", "http://w3schools.com/my test.asp?name=ståle&car=saab")
-]