Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #11267; closes #11259; closes #11085; add testcases #20505

Merged
merged 3 commits into from
Oct 5, 2022

Conversation

ringabout
Copy link
Member

@ringabout ringabout commented Oct 5, 2022

closes #11267; closes #11259; closes #11085

@ringabout ringabout mentioned this pull request Oct 5, 2022
15 tasks
@ringabout ringabout changed the title closes #11267; add testcase closes #11267; closes #11259; add testcases Oct 5, 2022
@ringabout ringabout changed the title closes #11267; closes #11259; add testcases closes #11267; closes #11259; closes #11085; add testcases Oct 5, 2022
@Varriount
Copy link
Contributor

How does this fix those issues? Only test cases appear to have been added.

@ringabout
Copy link
Member Author

ringabout commented Oct 5, 2022

How does this fix those issues? Only test cases appear to have been added.

The issues have been fixed on the devel branch, #20091 fixes them most likely though there are some edge cases.

@ringabout ringabout merged commit a600dfa into devel Oct 5, 2022
@ringabout ringabout deleted the pr_type_inference branch October 5, 2022 18:30
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from a600dfa

Hint: mm: orc; opt: speed; options: -d:release
162676 lines; 7.690s; 665.039MiB peakmem

capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
narimiran pushed a commit that referenced this pull request May 11, 2023
* closes #11267; add testcase

* closes #11259

* closes #11085

(cherry picked from commit a600dfa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants