add default field support for object in ARC/ORC #20480

ringabout · 2022-10-02T09:43:57Z

closes nim-lang/RFCs#126
closes nim-lang/RFCs#48
closes nim-lang/RFCs#233
closes nim-lang/RFCs#252
closes #12378
fixes #19763
fixes #16744
fixes #3608
ref nim-lang/RFCs#437

inspired by #12378

default fields for object

object variant

the addition compared to #12378

notes for me only

abstractInst vs {tyGenericInst, tyAlias, tySink}

…st-branch

ringabout · 2022-10-02T13:33:53Z

In the following up PRs, there are few improvements which can be applied:

provide a typetrait proc to detect whether the type has a default value
provides a cache table for analyzed types
provides a {.noInitDefaultValue.} (?) for procs
documentation

Araq · 2022-10-03T11:09:17Z

compiler/semstmts.nim

@@ -680,6 +689,9 @@ proc semVarOrLet(c: PContext, n: PNode, symkind: TSymKind): PNode =
        addToVarSection(c, result, n, a)
        continue
      var v = semIdentDef(c, a[j], symkind, false)
+      if {sfThread, sfNoInit} * v.flags != {}:
+        a[^1] = c.graph.emptyNode
+        def = c.graph.emptyNode


Seems to be a bad idea, what about var x {.noInit.} = f()? You turn this into var x {.noInit.} = <default>? Why?

My bad, I forget to consider that situation. Now I use a node flag to distinguish whether the node is from default field initialization or from explicit initialization ee53173

nfUseDefaultField is originally used for object fields and the two usages don't overlap.

Araq · 2022-10-03T11:10:00Z

compiler/semstmts.nim

@@ -1639,6 +1651,20 @@ proc addResult(c: PContext, n: PNode, t: PType, owner: TSymKind) =
      n.add newSymNode(c.p.resultSym)
    addParamOrResult(c, c.p.resultSym, owner)

+proc addDefaultFieldForResult(c: PContext, n: PNode, t: PType) =


addDefaultFieldForResult adds default values for implicit variables within procs:

transform

proc foo(): Object = discard

into

proc foo(): Object = result = Object() discard

So that default values are applied.

This is unnecessary if we do nim-lang/RFCs#378 and I think we should.

I will undo the default fields for results.

Araq · 2022-10-04T05:10:12Z

compiler/semstmts.nim

-      let field = defaultNodeField(c, a[^2])
-      if field != nil:
-        a[^1] = field
+      let m = copyTree(a[0])


Why does this need a copyTree here?

It is an old change and has been removed since ee53173. And it didn't work since semIdentDef(c, m, symkind, false) affected the ic tests.

github-actions · 2022-10-04T10:50:46Z

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from f89ba2c

Hint: mm: orc; opt: speed; options: -d:release
162695 lines; 8.563s; 665.113MiB peakmem

metagn · 2022-10-28T12:45:18Z

Was this documented? Not in changelog either

ringabout · 2022-10-28T12:58:37Z

It will be documented after bugs are fixed.

* fresh start * add cpp target * add result support * add nimPreviewRangeDefault * reduce * use orc * refactor common parts * add tuple support * add testcase for tuple * cleanup; fixes nimsuggest tests * there is something wrong with cpp * remove * add support for seqs * fixes style * addd initial distinct support * remove links * typo * fixes tuple defaults * add rangedefault * add cpp support * fixes one more bugs * add more hasDefaults * fixes ordinal types * add testcase for nim-lang#16744 * add testcase for nim-lang#3608 * fixes docgen * small fix * recursive * fixes * cleanup and remove tuple support * fixes nimsuggest * fixes generics procs * refactor * increases timeout * refactor hasDefault * zero default; disable i386 * add tuples back * fixes bugs * fixes tuple * add more tests * fix one more bug regarding tuples * more tests and cleanup * remove messy distinct types which must be initialized by original types * add tests * fixes zero default * fixes grammar * fixes tests * fixes tests * fixes tests * fixes comments * fixes and add testcase * undo default values for results Co-authored-by: flywind <43030857+xflywind@users.noreply.github.com>

* fresh start * add cpp target * add result support * add nimPreviewRangeDefault * reduce * use orc * refactor common parts * add tuple support * add testcase for tuple * cleanup; fixes nimsuggest tests * there is something wrong with cpp * remove * add support for seqs * fixes style * addd initial distinct support * remove links * typo * fixes tuple defaults * add rangedefault * add cpp support * fixes one more bugs * add more hasDefaults * fixes ordinal types * add testcase for #16744 * add testcase for #3608 * fixes docgen * small fix * recursive * fixes * cleanup and remove tuple support * fixes nimsuggest * fixes generics procs * refactor * increases timeout * refactor hasDefault * zero default; disable i386 * add tuples back * fixes bugs * fixes tuple * add more tests * fix one more bug regarding tuples * more tests and cleanup * remove messy distinct types which must be initialized by original types * add tests * fixes zero default * fixes grammar * fixes tests * fixes tests * fixes tests * fixes comments * fixes and add testcase * undo default values for results Co-authored-by: flywind <43030857+xflywind@users.noreply.github.com> (cherry picked from commit f89ba2c)

ringabout and others added 30 commits May 18, 2022 10:35

fresh start

ad67b71

Merge remote-tracking branch 'upstream/devel' into pr_object_default

4c00f7a

add cpp target

dc9c8da

Merge branch 'devel' into pr_object_default

dfa5cc2

Merge branch 'devel' into pr_object_default

72f3d8f

Merge branch 'devel' into pr_object_default

723e474

Merge branch 'devel' into pr_object_default

78279d6

add result support

222d9f8

add nimPreviewRangeDefault

6f8d6e9

reduce

2a041c5

use orc

1fc40f5

refactor common parts

0aaf39b

add tuple support

666f144

add testcase for tuple

d76e5fc

cleanup; fixes nimsuggest tests

a94526f

there is something wrong with cpp

0808f64

remove

8a91de7

add support for seqs

e119505

fixes style

8013b1c

addd initial distinct support

05966a6

Merge branch 'devel' into test-branch

f01519a

remove links

d9d1504

Merge branch 'test-branch' of https://github.com/xflywind/Nim into te…

bca98b3

…st-branch

typo

53c8baf

fixes tuple defaults

036952c

add rangedefault

5052468

add cpp support

ec8fd15

fixes one more bugs

6a5014c

add more hasDefaults

fca41d4

fixes ordinal types

0754474

ringabout and others added 3 commits August 19, 2022 10:12

remove messy distinct types which must be initialized by original types

ff38a2a

add tests

9484db8

Merge remote-tracking branch 'upstream/devel' into pr/20220

d2c1234

ringabout mentioned this pull request Oct 2, 2022

add default field support for object in ARC/ORC #20220

Closed

19 tasks

ringabout added 5 commits October 2, 2022 17:50

fixes zero default

0b1542c

fixes grammar

1c60bb9

fixes tests

a4bb478

fixes tests

c58560f

fixes tests

245d9fa

Araq reviewed Oct 3, 2022

View reviewed changes

ringabout added 3 commits October 3, 2022 19:54

fixes comments

1d2b3f5

fixes and add testcase

ee53173

undo default values for results

7c82f8d

Araq reviewed Oct 4, 2022

View reviewed changes

Araq merged commit f89ba2c into nim-lang:devel Oct 4, 2022

ringabout mentioned this pull request Oct 17, 2022

Roadmap for Nim nim-lang/RFCs#437

Closed

33 tasks

ringabout mentioned this pull request Oct 26, 2022

Initialization of base class variable #3816

Closed

PhilippMDoerner mentioned this pull request Oct 27, 2022

Can not use nim 2's new default instantiation with any object type with a DateTime field #20681

Closed

PhilippMDoerner mentioned this pull request Oct 29, 2022

Can not use nim 2's new default instantiation with any object type with a distinct DateTime field #20695

Closed

tersec mentioned this pull request Nov 9, 2022

--passC:"-O3" with ARC and ORC miscompile slice on nested seqs #19597

Closed

Menduist mentioned this pull request Nov 30, 2022

Limit number of streams per protocol per peer vacp2p/nim-libp2p#811

Merged

sgmihai mentioned this pull request Dec 29, 2022

Implement a constructor that allows initialization of the object with the assertion expressions defined in the struct sealmove/binarylang#26

Open

narimiran mentioned this pull request May 29, 2023

1.6.14 backport candidates nim-lang/backport#1

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add default field support for object in ARC/ORC #20480

add default field support for object in ARC/ORC #20480

ringabout commented Oct 2, 2022 •

edited

Loading

ringabout commented Oct 2, 2022 •

edited

Loading

Araq Oct 3, 2022

ringabout Oct 3, 2022 •

edited

Loading

Araq Oct 3, 2022

ringabout Oct 3, 2022

Araq Oct 3, 2022

ringabout Oct 3, 2022

ringabout Oct 3, 2022

Araq Oct 4, 2022

ringabout Oct 4, 2022 •

edited

Loading

github-actions bot commented Oct 4, 2022

metagn commented Oct 28, 2022

ringabout commented Oct 28, 2022

add default field support for object in ARC/ORC #20480

add default field support for object in ARC/ORC #20480

Conversation

ringabout commented Oct 2, 2022 • edited Loading

ringabout commented Oct 2, 2022 • edited Loading

Araq Oct 3, 2022

Choose a reason for hiding this comment

ringabout Oct 3, 2022 • edited Loading

Choose a reason for hiding this comment

Araq Oct 3, 2022

Choose a reason for hiding this comment

ringabout Oct 3, 2022

Choose a reason for hiding this comment

Araq Oct 3, 2022

Choose a reason for hiding this comment

ringabout Oct 3, 2022

Choose a reason for hiding this comment

ringabout Oct 3, 2022

Choose a reason for hiding this comment

Araq Oct 4, 2022

Choose a reason for hiding this comment

ringabout Oct 4, 2022 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Oct 4, 2022

metagn commented Oct 28, 2022

ringabout commented Oct 28, 2022

ringabout commented Oct 2, 2022 •

edited

Loading

ringabout commented Oct 2, 2022 •

edited

Loading

ringabout Oct 3, 2022 •

edited

Loading

ringabout Oct 4, 2022 •

edited

Loading